Delete GlobalConfigProvider #7914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Dec 12, 2025
| OpenTelemetryConfigurationModel model, DeclarativeConfigContext context) { | ||
| SdkConfigProvider sdkConfigProvider = SdkConfigProvider.create(model); | ||
| SdkConfigProvider sdkConfigProvider = | ||
| SdkConfigProvider.create(model, context.getSpiHelper().getComponentLoader()); |
Member
Author
There was a problem hiding this comment.
This was a bug! The SdkConfigProvider instance was not being created with the component loader specified in DeclarativeConfigContext.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7914 +/- ##
============================================
+ Coverage 90.10% 90.12% +0.02%
+ Complexity 7325 7319 -6
============================================
Files 825 824 -1
Lines 22051 22027 -24
Branches 2179 2177 -2
============================================
- Hits 19868 19851 -17
+ Misses 1504 1500 -4
+ Partials 679 676 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zeitlinger
approved these changes
Dec 13, 2025
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
great - I'll create a PR for agent to adjust
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is obsolete now that #7496 introduced
ExtendedOpenTelemetry. Allows for several nice simplifications!