Skip to content

Fix MarshalerUtil sizeRepeatedString calculation per issue#8272#8284

Merged
jack-berg merged 2 commits intoopen-telemetry:mainfrom
jhalliday:jh-profiling-s
Apr 16, 2026
Merged

Fix MarshalerUtil sizeRepeatedString calculation per issue#8272#8284
jack-berg merged 2 commits intoopen-telemetry:mainfrom
jhalliday:jh-profiling-s

Conversation

@jhalliday
Copy link
Copy Markdown
Contributor

The encoding of a zero length String as a single element is zero length (i.e. elided), but when encoded as an element of an array (i.e. 'repeated bytes' protobuf field) it's non-zero length, as space on the wire must still be used for the tag to denote the unoccupied location in the array.

@jhalliday jhalliday requested a review from a team as a code owner April 13, 2026 12:32
@jack-berg
Copy link
Copy Markdown
Member

Build will pass once you merge / rebase main.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.25%. Comparing base (ca41b47) to head (487c0cc).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...metry/exporter/internal/marshal/MarshalerUtil.java 33.33% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8284      +/-   ##
============================================
- Coverage     90.25%   90.25%   -0.01%     
- Complexity     7683     7684       +1     
============================================
  Files           850      850              
  Lines         23190    23191       +1     
  Branches       2353     2353              
============================================
  Hits          20930    20930              
  Misses         1533     1533              
- Partials        727      728       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jack-berg jack-berg merged commit 00f950a into open-telemetry:main Apr 16, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants