Rename MeterSharedState with MeterProviderSharedState#875
Merged
bogdandrutu merged 1 commit intoopen-telemetry:masterfrom Feb 19, 2020
Merged
Rename MeterSharedState with MeterProviderSharedState#875bogdandrutu merged 1 commit intoopen-telemetry:masterfrom
bogdandrutu merged 1 commit intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
============================================
- Coverage 82.99% 82.95% -0.04%
Complexity 823 823
============================================
Files 107 107
Lines 2869 2869
Branches 253 253
============================================
- Hits 2381 2380 -1
Misses 375 375
- Partials 113 114 +1
Continue to review full report at Codecov.
|
jkwatson
reviewed
Feb 19, 2020
218ee24 to
7f56496
Compare
Contributor
|
This seems fine, but I'm not sure why it's necessary. Is MeterSharedState not clear as to what it's about? |
Member
Author
|
@jkwatson I will also have a MeterSharedState which is the meter shared state between instruments which includes library info and other meter specific things. |
jkwatson
approved these changes
Feb 19, 2020
Contributor
|
looks like it needs a rebase |
Signed-off-by: Bogdan Cristian Drutu <bogdandrutu@gmail.com>
7f56496 to
f2804d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.