Handle out-of-order destruction of Fibers/DebugScopes during final shutdown#1209
Merged
brettmc merged 3 commits intoopen-telemetry:mainfrom Jan 13, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1209 +/- ##
============================================
- Coverage 83.29% 83.26% -0.03%
- Complexity 2250 2256 +6
============================================
Files 285 285
Lines 6404 6417 +13
============================================
+ Hits 5334 5343 +9
- Misses 1070 1074 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
brettmc
approved these changes
Jan 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable warnings for missing calls to
::detach()during the final shutdown phase if the scope is not destructed in the original fiber;DebugScope::__destruct()might be called before the fiber is resumed / before finally blocks that::detach()the scope are run.I wasn't able to create a simple reproducer; it happens for example with
amphp/file ^3.0andtbachert/otel-async-revolt-adapter 0.1.1.