Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
============================================
- Coverage 84.61% 84.58% -0.03%
+ Complexity 2137 2136 -1
============================================
Files 284 284
Lines 6056 6054 -2
============================================
- Hits 5124 5121 -3
- Misses 932 933 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bobstrecansky
approved these changes
Mar 13, 2024
agoallikmaa
approved these changes
Mar 14, 2024
agoallikmaa
left a comment
There was a problem hiding this comment.
Should be able to drop symfony/polyfill-php81 dependency.
Merged
Nevay
reviewed
Mar 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these are mostly automated changes from rector, applying 8.1 syntax updates.
also, apply some manual type-hint updates and readonly properties that rector missed.
after this is merged, we can separate create PRs to: