Allow immediate gc of ContextStorageNodes after ::detach()#1585
Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom May 7, 2025
Merged
Allow immediate gc of ContextStorageNodes after ::detach()#1585brettmc merged 1 commit intoopen-telemetry:mainfrom
ContextStorageNodes after ::detach()#1585brettmc merged 1 commit intoopen-telemetry:mainfrom
Conversation
Use dummy object instead of self references as detached-marker to avoid relying on gc cycle collection. Resolves open-telemetry#1584.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
============================================
+ Coverage 70.80% 70.89% +0.09%
Complexity 2768 2768
============================================
Files 407 407
Lines 8357 8359 +2
============================================
+ Hits 5917 5926 +9
+ Misses 2440 2433 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
brettmc
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use dummy object instead of self references as detached-marker to avoid relying on gc cycle collection.
Resolves #1584.