Allows API packages to specify file-based and env-based config#1621
Merged
brettmc merged 9 commits intoopen-telemetry:mainfrom Jun 16, 2025
Merged
Allows API packages to specify file-based and env-based config#1621brettmc merged 9 commits intoopen-telemetry:mainfrom
brettmc merged 9 commits intoopen-telemetry:mainfrom
Conversation
Contributor
|
Should I base #1523 on the back of this, given the environment changes here? 🤔 (I appreciate that my PR is a little stale, but I plan to pick it up again in future) |
Contributor
Author
Contributor
|
Failing pipelines look to be related to Xdebug issues that Brett raised in #1554; still present in 3.4.3. Noted that there is a 3.4.4 to address some issues, but looks like re-running the build hasn't picked up that extension version yet. |
brettmc
reviewed
Jun 13, 2025
e6c14f8 to
53796a3
Compare
53796a3 to
eacc55a
Compare
ChrisLightfootWild
approved these changes
Jun 15, 2025
brettmc
approved these changes
Jun 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
ComponentProviderand related classes to API and adds env-based loader to allow API packages (instrumentations and propagators) to specify their configuration options.