Skip to content

feat(carreirs): implement environment context getter setter#1668

Merged
brettmc merged 7 commits intoopen-telemetry:mainfrom
ycchuang99:feature/environment-context-propagation
Aug 4, 2025
Merged

feat(carreirs): implement environment context getter setter#1668
brettmc merged 7 commits intoopen-telemetry:mainfrom
ycchuang99:feature/environment-context-propagation

Conversation

@ycchuang99
Copy link
Copy Markdown
Contributor

Closes #1566

@ycchuang99 ycchuang99 requested a review from a team as a code owner July 20, 2025 20:37
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Jul 20, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@ycchuang99 ycchuang99 force-pushed the feature/environment-context-propagation branch 2 times, most recently from 52e48e9 to 8b2461d Compare July 20, 2025 20:43
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.75%. Comparing base (e54a43d) to head (f184ccf).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1668      +/-   ##
============================================
- Coverage     68.76%   68.75%   -0.01%     
- Complexity     2857     2867      +10     
============================================
  Files           425      426       +1     
  Lines          8704     8721      +17     
============================================
+ Hits           5985     5996      +11     
- Misses         2719     2725       +6     
Flag Coverage Δ
8.1 68.42% <100.00%> (-0.02%) ⬇️
8.2 68.61% <100.00%> (+0.06%) ⬆️
8.3 68.62% <100.00%> (+0.06%) ⬆️
8.4 68.66% <100.00%> (-0.01%) ⬇️
8.5 68.69% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/Context/Propagation/EnvironmentGetterSetter.php 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54a43d...f184ccf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

{
protected function tearDown(): void
{
putenv('A');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have OpenTelemetry\Tests\TestState trait to handle setting and cleaning up the environment.

@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Jul 21, 2025

How does one use this in conjunction with existing propagators? Could you add an example under the examples dir?

@ycchuang99
Copy link
Copy Markdown
Contributor Author

How does one use this in conjunction with existing propagators? Could you add an example under the examples dir?

Thanks for the review! Yes, I’ll add an example.

@ycchuang99 ycchuang99 marked this pull request as draft July 23, 2025 01:51
@ycchuang99 ycchuang99 force-pushed the feature/environment-context-propagation branch from 26c320a to 90734fa Compare July 31, 2025 07:42
@ycchuang99 ycchuang99 force-pushed the feature/environment-context-propagation branch from 90734fa to f184ccf Compare July 31, 2025 07:47
@ycchuang99 ycchuang99 marked this pull request as ready for review July 31, 2025 07:54
@ycchuang99 ycchuang99 requested a review from brettmc July 31, 2025 07:55
@brettmc brettmc merged commit 7981956 into open-telemetry:main Aug 4, 2025
10 of 11 checks passed
@ycchuang99 ycchuang99 deleted the feature/environment-context-propagation branch August 12, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[spec 1.44.0] implement environment variable context propagation

2 participants