Move instrumentation opentracing shim#109
Closed
NathanielRN wants to merge 15 commits intoopen-telemetry:masterfrom
Closed
Move instrumentation opentracing shim#109NathanielRN wants to merge 15 commits intoopen-telemetry:masterfrom
NathanielRN wants to merge 15 commits intoopen-telemetry:masterfrom
Conversation
…#922) This uses the OpenTelemetry context management mechanism to store a ScopeShim object in order to make active return the same object as the one returned by start_active_span.
…between OpenTelemetry and OpenTracing spans (open-telemetry#924)
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
* dropping support for python 3.4
* updating changelogs and version to 0.13b0
…text (open-telemetry#1146) Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
…pen-telemetry#1196) Co-authored-by: alrex <aboten@lightstep.com>
codeboten
suggested changes
Nov 2, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
The OpenTracing bridge must remain in the core repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes for package
instrumentation/opentelemetry-instrumentation-opentracing-shim.Adds remaining changes needed to get instrumentation packages to tag
v0.15b0at open-telemetry/opentelemetry-python@725655a of the Core RepoType of change
Please delete options that are not relevant.
How Has This Been Tested?
Tests will be added in a future PR
Checklist:
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated