Skip to content

Instrumenting sqlalchemy#22

Closed
codeboten wants to merge 9 commits intomasterfrom
codeboten/instrumentor-sqlalchemy
Closed

Instrumenting sqlalchemy#22
codeboten wants to merge 9 commits intomasterfrom
codeboten/instrumentor-sqlalchemy

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

@codeboten codeboten commented Apr 4, 2020

Porting the existing sqlalchemy instrumentation to using the OpenTelemetry API and the OpenTelemetry Auto-instrumentation Patcher interface.

The process to make this happen is pretty straight forward:

  1. move the redis code into the instrumentors directory
  2. move tests
  3. added setup/version files and move code into a similar directory structure to other opentelemetry integrations
  4. fixed relative import paths to using ddtrace package
  5. update the code to use opentelemetry API
  6. get tests running

Couple of TODOs left:

  1. add to travis
  2. the original sqlalchemy instrumentation set a couple of metrics in the metadata, this could be a good opportunity to use the metrics API
  3. figure out if Pin is needed

NOTE: This currently still uses some utility functions in the ddtrace package.

fixes #13

@codeboten codeboten marked this pull request as ready for review April 8, 2020 00:26
@codeboten codeboten requested a review from a team April 10, 2020 20:46
@codeboten
Copy link
Copy Markdown
Contributor Author

closing in favour of open-telemetry/opentelemetry-python#591

@codeboten codeboten closed this Apr 17, 2020
@codeboten codeboten deleted the codeboten/instrumentor-sqlalchemy branch November 24, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add instrumentor for SQLAlchemy

1 participant