OpenAI instrumentation docs fixes#2988
Merged
xrmx merged 17 commits intoopen-telemetry:mainfrom Dec 2, 2024
Merged
Conversation
github-actions
bot
requested review from
gyliu513,
karthikscale3,
lzchen and
nirga
3 tasks
dasiths
approved these changes
Nov 9, 2024
8 tasks
alizenhom
approved these changes
Nov 9, 2024
instrumentation-genai/opentelemetry-instrumentation-openai-v2/README.rst
Show resolved
Hide resolved
gyliu513
reviewed
Nov 11, 2024
instrumentation-genai/opentelemetry-instrumentation-openai-v2/README.rst
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/README.rst
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/README.rst
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Nov 12, 2024
instrumentation-genai/opentelemetry-instrumentation-openai-v2/README.rst
Show resolved
Hide resolved
lmolkova
force-pushed
the
openai-docs-fixes
branch
from
a7c0f9a to
b90948a
Compare
lmolkova
force-pushed
the
openai-docs-fixes
branch
2 times, most recently
from
2299149 to
26c92b5
Compare
karthikscale3
approved these changes
Nov 21, 2024
lzchen
reviewed
Nov 21, 2024
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/zero-code/README.rst
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Nov 21, 2024
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/zero-code/README.rst
Show resolved
Hide resolved
lzchen
requested changes
Nov 21, 2024
Contributor
lzchen
left a comment
lzchen
left a comment
There was a problem hiding this comment.
Some additional comments.
lmolkova
force-pushed
the
openai-docs-fixes
branch
from
26c92b5 to
b442f8f
Compare
8 tasks
added 2 commits
November 22, 2024 14:11
lzchen
approved these changes
Nov 23, 2024
Contributor
|
fyi an end user just noticed the 404 which I think this aims to fix. is there anything left that needs help on? |
Contributor
|
Merging main to check if we need to pin httpx<0.28.0 also for new openai versions |
Contributor
|
IIUC, the link fix is coupled to the latest version in pypi, so it won't correct until the next release, right? |
Contributor
Yeah, changes to pyproject.toml will be available in the next release |
xrmx
added a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
* Add openai docs config and improve readme * up * Add manual sample, add no-content tests * update headers * lint * use grpc endpoint in openai samples, add extra env vars to readme * move distro fix to another PR * nits * Ignore examples for pylint * Update .pylintrc * ignroe lint for example * Fix README docs * Update openai.rst * Update conf.py * Update docs-requirements.txt * docs --------- Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.