OpenAI v2 onboard onto semantic conventions 1.37.0: chat history and other breaking changes#3715
Conversation
|
As a common package we have https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/util/opentelemetry-util-genai |
|
thanks a lot, @xrmx! |
zhirafovod
left a comment
There was a problem hiding this comment.
Some minor suggestions, but overall it looks good for this iteration. Thanks for doing it, we can add some notes to follow up on these items in the following pr.
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/manual/.env
Outdated
Show resolved
Hide resolved
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Show resolved
Hide resolved
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Outdated
Show resolved
Hide resolved
@xrmx , I would propose we merge this one before the common library is ready. It will provide testing needed to switch to the new library. Also, please review the PRs which are pre-requirement to switching to the util library. |
4d9ba77 to
4887a19
Compare
instrumentation-genai/opentelemetry-instrumentation-openai-v2/tests/test_utils.py
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/pyproject.toml
Outdated
Show resolved
Hide resolved
a1bbbf9 to
3f0e18a
Compare
3f0e18a to
50f4210
Compare
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/manual/.env
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/zero-code/.env
Outdated
Show resolved
Hide resolved
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Outdated
Show resolved
Hide resolved
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Show resolved
Hide resolved
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/zero-code/.env
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/zero-code/.env
Outdated
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/manual/.env
Outdated
Show resolved
Hide resolved
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-openai-v2/examples/manual/.env
Show resolved
Hide resolved
vasantteja
left a comment
There was a problem hiding this comment.
@lmolkova Overall LGTM!! I left few questions behind so that we can consolidate stuff to further streamline and simplify the codebase. Lmk your thoughts.
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Show resolved
Hide resolved
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Outdated
Show resolved
Hide resolved
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Outdated
Show resolved
Hide resolved
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/patch.py
Outdated
Show resolved
Hide resolved
...ntelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/__init__.py
Outdated
Show resolved
Hide resolved
…y-python-contrib into openai-v2-input-output-attrs
…lkova/opentelemetry-python-contrib into openai-v2-input-output-attrs
…other breaking changes (open-telemetry#3715) * Support latest experimental conventions in openai * format * changelog * lint * lint * update to use new test utils, fix tests * lint * review * address feedback * review * feedback: more readable
…other breaking changes (open-telemetry#3715) * Support latest experimental conventions in openai * format * changelog * lint * lint * update to use new test utils, fix tests * lint * review * address feedback * review * feedback: more readable
Implements new semconv 1.37.0 behind
OTEL_SEMCONV_STABILITY_OPT_IN = gen_ai_latest_experimentalopt-in.TODOs: