Add DB-API sqlcomment mysql_client_version fallback#3729
Merged
xrmx merged 20 commits intoopen-telemetry:mainfrom Jan 26, 2026
Merged
Add DB-API sqlcomment mysql_client_version fallback#3729xrmx merged 20 commits intoopen-telemetry:mainfrom
xrmx merged 20 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Oct 10, 2025
Contributor
xrmx
left a comment
xrmx
left a comment
There was a problem hiding this comment.
Please add some docker tests, I fixed a crash in the psycopg commenter code extracting the libpq version recently and the mocks were not matching reality.
xrmx
moved this from Ready for review
to Reviewed PRs that need fixes
in Python PR digest
Contributor
Author
@xrmx done, ptal. I tried to add one for the |
emdneto
reviewed
Nov 13, 2025
tammy-baylis-swi
moved this from Reviewed PRs that need fixes
to Ready for review
in Python PR digest
Contributor
Author
xrmx
reviewed
Jan 21, 2026
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Outdated
Show resolved
Hide resolved
tammy-baylis-swi
force-pushed
the
mysql-client-comment-field-fallback
branch
from
3d7ecf8 to
3249647
Compare
xrmx
approved these changes
Jan 22, 2026
emdneto
approved these changes
Jan 26, 2026
github-project-automation
bot
moved this from Ready for review
to Done
in Python PR digest
wikaaaaa
pushed a commit
to wikaaaaa/opentelemetry-python-contrib
that referenced
this pull request
Feb 5, 2026
) * Add dbapi comment mysql_client_version fallback * Changelog * Add docker test_mysql_sqlcommenter * Update dbapi docker-tests * Add test fetchall * Add test case for cmysql unknown * Change to patch * Rm test attempt * Changelog * simplify commenter_data assn * Add Pure Python mysql_client_version unknown test --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
) * Add dbapi comment mysql_client_version fallback * Changelog * Add docker test_mysql_sqlcommenter * Update dbapi docker-tests * Add test fetchall * Add test case for cmysql unknown * Change to patch * Rm test attempt * Changelog * simplify commenter_data assn * Add Pure Python mysql_client_version unknown test --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stops stacktraces when programmatic instrumentation with sqlcommenting is enabled in some cases.
Fixes #3730
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.