feature: hydrate AsyncPG span attributes at creation#3841
Merged
xrmx merged 12 commits intoopen-telemetry:mainfrom Dec 22, 2025
Merged
feature: hydrate AsyncPG span attributes at creation#3841xrmx merged 12 commits intoopen-telemetry:mainfrom
xrmx merged 12 commits intoopen-telemetry:mainfrom
Conversation
forafox
force-pushed
the
feature/asyncpg-attribute-hydration
branch
from
4a779d1 to
881bc76
Compare
xrmx
reviewed
Nov 28, 2025
xrmx
moved this from Ready for review
to Easy to review / merge / close
in Python PR digest
Contributor
Author
The sampler now receives DB system/name/user, DB statement (and parameters when capture_parameters is on), and peer host/port/transport because we hydrate attributes before start_as_current_span. Added tests covering execute and cursor paths with non-recording spans to ensure those attributes are present for sampling decisions, and added a changelog entry |
Contributor
|
Thanks for contributing! Please also have a look at the docker-tests, and do a |
Contributor
Author
Hi! Thanks for the feedback — I’ve addressed the formatting issues and updated the docker tests as requested. |
tests/opentelemetry-docker-tests/tests/asyncpg/test_asyncpg_functional.py
Outdated
Show resolved
Hide resolved
tests/opentelemetry-docker-tests/tests/asyncpg/test_asyncpg_functional.py
Outdated
Show resolved
Hide resolved
tammy-baylis-swi
approved these changes
Dec 9, 2025
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thanks for revisions, lgtm!
xrmx
approved these changes
Dec 22, 2025
xrmx
changed the title
github-project-automation
bot
moved this from Easy to review / merge / close
to Done
in Python PR digest
herin049
pushed a commit
to herin049/opentelemetry-python-contrib
that referenced
this pull request
Dec 22, 2025
…3841) * feature: hydrate AsyncPG span attributes at creation (open-telemetry#3643) * opentelemetry-instrumentation-asyncpg: ensure sampler sees span attributes * tests: fix import order in asyncpg docker tests * tests: expect net.transport in asyncpg sampler attributes * tests: use sdk tracer in asyncpg sampling checks * changelog: move asyncpg fix to Unreleased * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
RKest
pushed a commit
to RKest/opentelemetry-python-contrib
that referenced
this pull request
Jan 12, 2026
…3841) * feature: hydrate AsyncPG span attributes at creation (open-telemetry#3643) * opentelemetry-instrumentation-asyncpg: ensure sampler sees span attributes * tests: fix import order in asyncpg docker tests * tests: expect net.transport in asyncpg sampler attributes * tests: use sdk tracer in asyncpg sampling checks * changelog: move asyncpg fix to Unreleased * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
…3841) * feature: hydrate AsyncPG span attributes at creation (open-telemetry#3643) * opentelemetry-instrumentation-asyncpg: ensure sampler sees span attributes * tests: fix import order in asyncpg docker tests * tests: expect net.transport in asyncpg sampler attributes * tests: use sdk tracer in asyncpg sampling checks * changelog: move asyncpg fix to Unreleased * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change enables filtering of AsyncPG spans by moving attribute hydration from inside the span context to before span creation. Previously, spans were created with no attributes and attributes were added after span creation using
span.set_attribute(), which prevented samplers from filtering based on request attributes.The fix moves the
_hydrate_span_from_args()call outside the span context and passes the hydrated attributes directly tostart_as_current_span()using theattributesparameter. This ensures that database attributes (system, name, user, statement, network info) are available during span creation for sampling decisions.Fixes #3643
Type of change
How Has This Been Tested?
The changes were tested by:
attributesparameter is properly passed tostart_as_current_span()in both_do_executeand_do_cursor_executemethodsThe implementation maintains backward compatibility and does not change the external API.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.