pymongo: for CommandFailedEvent use the errmsg as the status description instead of the _DocumentOut #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshok
changed the title
xrmx
reviewed
Oct 31, 2025
xrmx
moved this from Ready for review
to Easy to review / merge / close
in @xrmx's Python PR digest
toshok
force-pushed
the
toshok/span-status-requires-str-description
branch
from
64e51c1 to
6ab7ace
Compare
Contributor
Author
👍 and rebase off current main HEAD |
…as a str, when that's not what the type is)
toshok
force-pushed
the
toshok/span-status-requires-str-description
branch
from
6ab7ace to
859d1f4
Compare
xrmx
approved these changes
Nov 11, 2025
xrmx
moved this from Easy to review / merge / close
to Approved PRs
in @xrmx's Python PR digest
github-project-automation
bot
moved this from Approved PRs
to Done
in @xrmx's Python PR digest
herin049
pushed a commit
to herin049/opentelemetry-python-contrib
that referenced
this pull request
Nov 17, 2025
…ion instead of the _DocumentOut (open-telemetry#3904) * use the errmsg as the status description instead of the _DocumentOut * fix the unit tests (in particular the test was mocking event.failure as a str, when that's not what the type is) * reformat, fix tests * add changelog --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when a pymongo command fails, this warning is printed to the console:
We tracked this down to the line changed in this PR. It's attempting to send a
_DocumentOutas the status description.The change fixes the issue and puts
errmsgin the status, butstr(error.failure)(similar to the other place we set the span status) would likely also work.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Modified pymongo tests that call
CommandTracer#failedto mark failures using adict, which is compatible with the pymongo_DocumentOuttype wrt howerrmsgis pulled out.test_pymongo.go/test_failedtest_pymongo.go/test_multiple_commandsDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.