Skip to content

fix: confluent-kafka: fix incorrect number of arguments#3922

Merged
xrmx merged 4 commits intoopen-telemetry:mainfrom
papigers:confluent-kafka-fix-close-incorrect-num-args
Jan 26, 2026
Merged

fix: confluent-kafka: fix incorrect number of arguments#3922
xrmx merged 4 commits intoopen-telemetry:mainfrom
papigers:confluent-kafka-fix-close-incorrect-num-args

Conversation

@papigers
Copy link
Copy Markdown
Contributor

@papigers papigers commented Nov 5, 2025

Description

Incorrect wrapping of close() results in the following error:

TypeError: ConfluentKafkaInstrumentor._instrument.<locals>._inner_wrap_close() takes 2 positional arguments but 4 were given

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@papigers papigers requested a review from a team as a code owner November 5, 2025 12:39
@papigers papigers force-pushed the confluent-kafka-fix-close-incorrect-num-args branch from f72ac65 to 6dbb8eb Compare November 5, 2025 12:42
@papigers
Copy link
Copy Markdown
Contributor Author

papigers commented Nov 5, 2025

@emdneto hoping that you can help with CR here 🙏

@xrmx xrmx moved this to Ready for review in Python PR digest Nov 5, 2025
@xrmx xrmx moved this from Ready for review to Reviewed PRs that need fixes in Python PR digest Nov 28, 2025
@xrmx xrmx merged commit c1fe016 into open-telemetry:main Jan 26, 2026
663 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed PRs that need fixes to Done in Python PR digest Jan 26, 2026
wikaaaaa pushed a commit to wikaaaaa/opentelemetry-python-contrib that referenced this pull request Feb 5, 2026
…ry#3922)

* confluent-kafka: fix incorrect number of arguments

* update confluent-kafka dep

* changelog

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
sightseeker added a commit to sightseeker/opentelemetry-python-contrib that referenced this pull request Mar 11, 2026
…ry#3922)

* confluent-kafka: fix incorrect number of arguments

* update confluent-kafka dep

* changelog

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants