openai-v2: handle NotGiven values in request parameters #3926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rumentation for chat.completions.create operations
xrmx
changed the title
Closed
8 tasks
Kludex
reviewed
Nov 10, 2025
...opentelemetry-instrumentation-openai-v2/src/opentelemetry/instrumentation/openai_v2/utils.py
Outdated
Show resolved
Hide resolved
lmolkova
approved these changes
Nov 18, 2025
herin049
pushed a commit
to herin049/opentelemetry-python-contrib
that referenced
this pull request
Dec 22, 2025
…ry#3926) * fix: remove attributes where the value is NOT_GIVEN in openai-v2 instrumentation for chat.completions.create operations * Generalize check for instances of NotGiven * Test embeddings for NotGiven values * Bump tested openai version to latest * Add a test README for giving hints on recording tests cassettes * Fix lint * Fix CI for oldest * Add missing type * Stick to older jiter for PyPy * Move test README in tests * Add response_service_tier to test assertion --------- Co-authored-by: bkawecki <bkbkawecki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR filters out attributes where the value is
NOT_GIVENornot_givenform the llm_request_attributes dictionary. These values cannot be set as an attribute value and should be treated as equivalent to None.This warning message is generated in
opentelemetry.attributeshere.Example WARNING log:
Fixes #3921
Closes #3760
This is on top of #3760 but generalizes it and add tests for embeddings. While at it I've bumped the openai version in latest test requirement to latest available < 2 and added a README.md for documenting how to configure tox to let the OPENAI_API_KEY environment variable pass. No idea why I had to add
dataliboptional dependencies to the oldest requirements file.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.