Remove span attributes pymemcache #4076
Open
+37
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
herin049
reviewed
Jan 2, 2026
| ) | ||
| logger = logging.getLogger(__name__) | ||
|
|
||
| NET_TRANSPORT = "network.transport" |
Contributor
There was a problem hiding this comment.
You should be using from opentelemetry.semconv._incubating.attributes.net_attributes import NET_TRANSPORT here.
| address_attributes[NET_PEER_NAME] = host | ||
| address_attributes[NET_PEER_PORT] = port | ||
| address_attributes[NET_TRANSPORT] = ( | ||
| "tcp" |
Contributor
There was a problem hiding this comment.
We cannot perform this update here since there is no suitable alternative since the non-depricated NetworkTransportValues does not have ip_tcp as a value, and we want to ensure no breaking changes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces usage of the deprecated SpanAttributes with semconv constants.
Fixes # #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ptox run -e $(tox --listenvs | grep memcache | tr '\n' ',')
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.