opentelemetry-instrumentation-tortoiseorm: remove usage of deprecated SpanAttributes #4080
+22
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I created a new issue to add tests to this instrumentor 💀 #4086 I'm assuming no ImportError when all the lint/ruff passes. Does this run on local ok? |
Contributor
Author
|
@tammy-baylis-swi Yes, I assume we're good here. We can follow-up shortly to add the tests before the next release. |
tammy-baylis-swi
approved these changes
Jan 6, 2026
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Sounds good to me
emdneto
approved these changes
Jan 6, 2026
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces usage of the deprecated
SpanAttributeswith semconv constants.Refs #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox run -e $(tox --listenvs | grep tortoiseorm | tr '\n' ',')Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.