Skip to content

opentelemetry-instrumentation-urllib3: fix multiple arguments error#4144

Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom
herin049:fix/urllib3-multiple-arguments
Jan 28, 2026
Merged

opentelemetry-instrumentation-urllib3: fix multiple arguments error#4144
xrmx merged 3 commits intoopen-telemetry:mainfrom
herin049:fix/urllib3-multiple-arguments

Conversation

@herin049
Copy link
Copy Markdown
Contributor

@herin049 herin049 commented Jan 26, 2026

Description

Fixes issue where the urllib3 instrumentation library would call urlopen with headers passed as both a keyword and positional argument when headers are originally passed as a positional argument.

Fixes #4115
Closes #4143

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

 tox run -e $(tox --listenvs | grep urllib3 | tr '\n' ',')

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

@github-actions github-actions bot requested a review from shalevr January 26, 2026 20:11
@herin049 herin049 requested a review from a team as a code owner January 26, 2026 20:12
@herin049 herin049 force-pushed the fix/urllib3-multiple-arguments branch from cb0b09b to bafba16 Compare January 26, 2026 20:12
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hopping onto this

@xrmx xrmx moved this to Approved PRs in Python PR digest Jan 28, 2026
@xrmx xrmx enabled auto-merge (squash) January 28, 2026 16:40
@xrmx xrmx merged commit 262a097 into open-telemetry:main Jan 28, 2026
663 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Python PR digest Jan 28, 2026
wikaaaaa pushed a commit to wikaaaaa/opentelemetry-python-contrib that referenced this pull request Feb 5, 2026
…pen-telemetry#4144)

* opentelemetry-instrumentation-urllib3: fix multiple arguments error

* update CHANGELOG.md
sightseeker added a commit to sightseeker/opentelemetry-python-contrib that referenced this pull request Mar 11, 2026
…pen-telemetry#4144)

* opentelemetry-instrumentation-urllib3: fix multiple arguments error

* update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

TypeError: HTTPConnectionPool.urlopen() got multiple values for argument 'headers'

4 participants