opentelemetry-instrumentation-urllib3: fix multiple arguments error#4144
Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom Jan 28, 2026
Merged
Conversation
cb0b09b to
bafba16
Compare
7 tasks
tammy-baylis-swi
approved these changes
Jan 26, 2026
Contributor
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thanks for hopping onto this
xrmx
approved these changes
Jan 28, 2026
wikaaaaa
pushed a commit
to wikaaaaa/opentelemetry-python-contrib
that referenced
this pull request
Feb 5, 2026
…pen-telemetry#4144) * opentelemetry-instrumentation-urllib3: fix multiple arguments error * update CHANGELOG.md
sightseeker
added a commit
to sightseeker/opentelemetry-python-contrib
that referenced
this pull request
Mar 11, 2026
…pen-telemetry#4144) * opentelemetry-instrumentation-urllib3: fix multiple arguments error * update CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where the
urllib3instrumentation library would callurlopenwithheaderspassed as both a keyword and positional argument when headers are originally passed as a positional argument.Fixes #4115
Closes #4143
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.