Skip to content

Fix docker-tests assumption by Postgres-Sqlalchemy case about scope of metrics #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 2 commits into from
Feb 25, 2026
Merged

Fix docker-tests assumption by Postgres-Sqlalchemy case about scope of metrics #4258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aebd33
Fix postgres-sqlalchemy docker-test assumption about metrics
tammy-baylis-swi Feb 24, 2026
7e8be66
Changelog
tammy-baylis-swi Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#4078](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4171))
- `opentelemetry-instrumentation-aiohttp-server`: fix HTTP error inconsistencies
([#4175](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4175))
- `opentelemetry-docker-tests` Fix docker-tests assumption by Postgres-Sqlalchemy case about scope of metrics
([#4258](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4258))

### Breaking changes

Expand Down
4 changes: 3 additions & 1 deletion tests/opentelemetry-docker-tests/tests/sqlalchemy_tests/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

from .mixins import SQLAlchemyTestMixin

SCOPE = "opentelemetry.instrumentation.sqlalchemy"

POSTGRES_CONFIG = {
"host": "127.0.0.1",
"port": int(os.getenv("TEST_POSTGRES_PORT", "5432")),
Expand Down Expand Up @@ -117,7 +119,7 @@ def test_metrics_pool_name(self):
POSTGRES_CONFIG["port"],
self.SQL_DB,
)
metrics = self.get_sorted_metrics()
metrics = self.get_sorted_metrics(SCOPE)
self.assertEqual(len(metrics), 1)
self.assert_metric_expected(
metrics[0],
Expand Down