[Prototype] Move SpanContext into Span#1191
Closed
carlosalberto wants to merge 2 commits intoopen-telemetry:masterfrom
Closed
[Prototype] Move SpanContext into Span#1191carlosalberto wants to merge 2 commits intoopen-telemetry:masterfrom
carlosalberto wants to merge 2 commits intoopen-telemetry:masterfrom
Conversation
Contributor
|
Looks like the spec change was closed, are you ok with closing this PR @carlosalberto? |
Contributor
Author
|
Closing this as the related PR in the Specification as closed as well. |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…ry#1191) Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prototype for moving
SpanContextintoSpan(open-telemetry/opentelemetry-specification#1022)For simplicity purposes, only updated:
I'd like to get the Maintainers feedback - from my side here are my points:
Propagators (no instrumentation, based on my digging, would need to be greatly updated).Linkwill either referenceSpan(as shown in the prototype) or replicate the Trace/Span/ ids and flag/state. Not a pretty change, but it will work.cc @lzchen @codeboten in case I may have overseen either good or bad impacts of this change ;)