Skip to content

Setup SDK to be a Namespace Package so it can be extended #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 4 commits into from
Oct 15, 2020
Merged

Setup SDK to be a Namespace Package so it can be extended #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
569c098
SDK as namespace package makes it extendable
NathanielRN Oct 6, 2020
da07816
Merge branch 'master' into sdk-namespace-package
Oct 15, 2020
d8ccabd
Merge branch 'master' into sdk-namespace-package
Oct 15, 2020
73d9f4b
Merge branch 'master' into sdk-namespace-package
lzchen Oct 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...try-sdk/src/opentelemetry/sdk/__init__.py → ...ry-sdk/src/opentelemetry/sdk/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,3 @@
The OpenTelemetry SDK package is an implementation of the OpenTelemetry
API
"""
from . import metrics, trace, util
Comment thread
aabmass marked this conversation as resolved.

__all__ = ["metrics", "trace", "util"]
6 changes: 5 additions & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/metrics/export/in_memory_metrics_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@
import threading
from typing import Sequence

from . import MetricRecord, MetricsExporter, MetricsExportResult
from opentelemetry.sdk.metrics.export import (
MetricRecord,
MetricsExporter,
MetricsExportResult,
)


class InMemoryMetricsExporter(MetricsExporter):
Expand Down
3 changes: 1 addition & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/export/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@

from opentelemetry.configuration import Configuration
from opentelemetry.context import attach, detach, set_value
from opentelemetry.sdk.trace import Span, SpanProcessor
from opentelemetry.util import time_ns

from .. import Span, SpanProcessor

logger = logging.getLogger(__name__)


Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/trace/export/in_memory_span_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
import threading
import typing

from .. import Span
from . import SpanExporter, SpanExportResult
Comment thread
aabmass marked this conversation as resolved.
from opentelemetry.sdk.trace import Span
from opentelemetry.sdk.trace.export import SpanExporter, SpanExportResult


class InMemorySpanExporter(SpanExporter):
Expand Down