Version number normalization test#254
Closed
c24t wants to merge 1 commit intoopen-telemetry:masterfrom
Closed
Conversation
c24t
requested review from
Oberon00,
a-feld,
carlosalberto,
lzchen,
reyang and
toumorokoshi
as code owners
Member
|
Adding the test to every repository doesn't seem scalable. I could easily forget to add this snippet into my unit tests. Regarding the normalized version: I debate a little bit how important that is. part of the purpose of the version normalization is to ensure that developers don't have to worry about normalizing version strings themselves. If the goal is for .version to match what pkg_resources dictates, why not just modify the code so that version is retrieving the string from pkg_resources vs writing the value out ourselves? |
Member
|
I think such a test would best be provided as a separate script that is then invoked via eachdist.py (#291), so that you can't forget to add it for a new package. |
Contributor
|
Closing in favour of using setuptools scm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @Oberon00's comment: #250 (comment).
@Oberon00 do you think it's worth including tests like this?
This PR adds a test for each package to check that the version number is normalized, similar to the check in the Dynatrace OneAgent SDK. It checks that the verison is importable in each package, and matches the normalized version according to
pkg_resources.We're unlikely to make this particular mistake again, but it can't hurt to test it.