Fix docs generation issue in Travis build#267
Merged
c24t merged 1 commit intoopen-telemetry:masterfrom Nov 4, 2019
Merged
Conversation
hectorhdzg
requested review from
Oberon00,
a-feld,
c24t,
carlosalberto,
lzchen,
reyang and
toumorokoshi
as code owners
c24t
approved these changes
Nov 4, 2019
Member
c24t
left a comment
c24t
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing the build!
See the issue in sphinx-autodoc-typehints: https://github.com/agronholm/sphinx-autodoc-typehints/issues/117.
lzchen
approved these changes
Nov 4, 2019
Member
|
Merging to unblock builds, but we should pick an specific version for this and the other sphinx dependencies (or decide to use latest for build tools) since not every version < 1.9 will actually work here. |
This was referenced Nov 5, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: update readme * Update README.md Co-Authored-By: Olivier Albertini <olivier.albertini@montreal.ca> * fix: use full package names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest version of sphinx-autodoc-typehints is causing warnings in Travis build
https://pypi.org/project/sphinx-autodoc-typehints/#history
#263