Merged
Conversation
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
requested review from
Oberon00,
a-feld,
c24t,
carlosalberto,
lzchen,
reyang and
toumorokoshi
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 85.76% 85.76%
=======================================
Files 33 33
Lines 1609 1609
Branches 180 180
=======================================
Hits 1380 1380
Misses 182 182
Partials 47 47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@johananl Is this what you had in mind? Personally I'd prefer not having shortlinks here. |
Contributor
Author
|
Happy to change it to the full url, I don't have a strong preference either ways |
added 2 commits
November 29, 2019 08:20
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Contributor
Yup, the current status looks good to me. Thanks @codeboten! Nit: I would have liked to link to the actual |
lzchen
approved these changes
Dec 3, 2019
c24t
approved these changes
Dec 3, 2019
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Dec 4, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
closes open-telemetry#311 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
Signed-off-by: Alex Boten aboten@lightstep.com