docs: Consolidate getting started guide and remove duplicated examples#658
Merged
codeboten merged 5 commits intoopen-telemetry:masterfrom May 21, 2020
mauriciovasquezbernal:mauricio/consolidate-getting-started-guide
Merged
docs: Consolidate getting started guide and remove duplicated examples#658codeboten merged 5 commits intoopen-telemetry:masterfrom mauriciovasquezbernal:mauricio/consolidate-getting-started-guide
codeboten merged 5 commits intoopen-telemetry:masterfrom
mauriciovasquezbernal:mauricio/consolidate-getting-started-guide
Conversation
There are some examples that are duplicated in the getting started guide and in the examples folder itself. This commit removes the duplicated examples and updates the getting started guide to include then from real source files that are passed through the linter and have tests.
codeboten
added
the
needs reviewers
codeboten
approved these changes
May 21, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
I've reviewed the previews and I think it removes quite a bit of duplication from the docs. It also removes an extra build task which is no longer necessary with this change. Overall, I'm sure there will still be fixes needed to improve our docs, but its a step in the right direction.
c24t
approved these changes
May 21, 2020
Member
c24t
left a comment
c24t
left a comment
There was a problem hiding this comment.
Changes LGTM, and this looks like a step in the right direction for docs examples.
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* feat: plugin user interaction for web * chore: unnecessary check * chore: reviews * chore: adding version * chore: adding version * chore: reviews * chore: reviews * chore: reviews * chore: fixes after merge * chore: reviews * chore: updating version * chore: lint Co-authored-by: Mayur Kale <mayurkale@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #547
This PR:
To be done in follow up PRs
Preview: https://opentelemetry-python-mauricio.readthedocs.io/en/mauricio-consolidate-getting-started-guide/getting-started.html