Rename CounterAggregator -> SumAggregator#815
Closed
aabmass wants to merge 11 commits intoopen-telemetry:masterfrom
Closed
Rename CounterAggregator -> SumAggregator#815aabmass wants to merge 11 commits intoopen-telemetry:masterfrom
aabmass wants to merge 11 commits intoopen-telemetry:masterfrom
Conversation
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…lemetry#815) * chore: extract resources into their own package * feat: resource values can be numbers, strings, or booleans * feat: add constants for resource semantic conventions * feat: test utilities for validating resources * docs: improve docs * fix: lint errors * fix: test issues * Update packages/opentelemetry-resources/LICENSE Co-Authored-By: Daniel Dyla <dyladan@users.noreply.github.com> * docs: fix typos * docs: fix formatting for multi-line comments * chore: remove unused dependency Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #796 as requested by @lzchen. I also renamed a few variables names from
counter*->sum_agg*.