[WIP] add fastapi instrumentation#820
Closed
toumorokoshi wants to merge 21 commits intoopen-telemetry:masterfrom
Closed
[WIP] add fastapi instrumentation#820toumorokoshi wants to merge 21 commits intoopen-telemetry:masterfrom
toumorokoshi wants to merge 21 commits intoopen-telemetry:masterfrom
Conversation
tox does exact match on fields delimited by a dash. Thus, any instrumentation that includes "instrumentation" in the name would collide with testing of the "opentelemetry-instrumentation" package. Renaming the tox environment resolves the issue.
toumorokoshi
changed the title
Member
Author
|
closing and re-creating with a working, complete instrumentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty similar to #777. Starlette instrumentation also works for instrument_app, but not auto-instrumentation due to FastAPI not calling Starlette's init.
Thought it would be better long term to just make a separate code base entirely.