Skip to content

Clarify mutually exclusive options in span creation.#131

Merged
SergeyKanzhelev merged 3 commits intoopen-telemetry:masterfrom
songy23:spanbuilder
Jun 17, 2019
Merged

Clarify mutually exclusive options in span creation.#131
SergeyKanzhelev merged 3 commits intoopen-telemetry:masterfrom
songy23:spanbuilder

Conversation

@songy23
Copy link
Copy Markdown
Member

@songy23 songy23 commented Jun 17, 2019

Fixed the comment in #124 (comment).

time will be used as parent.

Note: The three parameters above (parent `Span`, parent `SpanContext` and `root`) are
mutually exclusive. If multiple parameters are specified or corresponding `Setter`s are
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we assume there will be multiple parameters. Probably we can leave it as a language specific decision?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG, added a note here.

@SergeyKanzhelev SergeyKanzhelev merged commit 7af04fa into open-telemetry:master Jun 17, 2019
@songy23 songy23 deleted the spanbuilder branch June 17, 2019 18:09
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
)

* Clarify mutually exclusive options in span creation.

* Fix indentation.

* Add a note about parameters being language-specific.
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this pull request Oct 15, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 21, 2024
…en-telemetry#131)

* add otlp export otep

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* fix format to pass markdownlint

* add sentence to highlight cumulative -> delta is also needed

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 23, 2024
…en-telemetry#131)

* add otlp export otep

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* Make SDK OTLP exporters support configurable export behavior

Based on discussions from the Metrics SIG meeting, configurable export behavior from the OTLP exporter is desired to support different mertic backends

* fix format to pass markdownlint

* add sentence to highlight cumulative -> delta is also needed

Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
)

* Clarify mutually exclusive options in span creation.

* Fix indentation.

* Add a note about parameters being language-specific.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants