Use semantic conventions v2 for weaver registry infer#1334
Use semantic conventions v2 for weaver registry infer#1334ArthurSens wants to merge 4 commits intoopen-telemetry:mainfrom
weaver registry infer#1334Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
=====================================
Coverage 81.8% 81.9%
=====================================
Files 119 119
Lines 9938 10021 +83
=====================================
+ Hits 8139 8211 +72
- Misses 1799 1810 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
You can either create one entity with everything or none. I think I'd prefer none until we get Entity populated, but I can see having something inferred better than nothing. We'll also need to deal with "loose" attributes for some time, so we should probably figure out the right behavior here.
We don't have a formal
YES! I think that should even help us with the migration from span-event to just event. |
| pub struct InferredRegistry { | ||
| /// Inferred semantic convention groups. | ||
| pub groups: Vec<GroupSpec>, | ||
| pub struct InferredRegistryV2 { |
There was a problem hiding this comment.
Is there a reason this is different than the actual struct/type we use for V2?
This seems to mostly by copy-paste from here - https://github.com/open-telemetry/weaver/blob/main/crates/weaver_semconv/src/v2/mod.rs#L54
You should be able to directly use that struct and wrap it in Versioned::V2(...struct...) when you need the manifest version.
There was a problem hiding this comment.
Mostly because it was all private in that crate. I've implemented constructors and accessors for it now :)
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
|
Comments addressed! |
Continuing the work we agreed on, this PR migrates the
weaver registry infercommand to the schema file's second version.There are a few open questions from my side, which I'd love some input from maintainers:
span.typeandspan.note. Should I be using something else for them?