Skip to content

Wip allow multiple dependencies part 2 - Use semver to resolve *some* dependency conflicts#1377

Draft
jsuereth wants to merge 20 commits intoopen-telemetry:mainfrom
jsuereth:wip-allow-multiple-dependencies-part-2
Draft

Wip allow multiple dependencies part 2 - Use semver to resolve *some* dependency conflicts#1377
jsuereth wants to merge 20 commits intoopen-telemetry:mainfrom
jsuereth:wip-allow-multiple-dependencies-part-2

Conversation

@jsuereth
Copy link
Copy Markdown
Contributor

With multiple dependencies, if two depend on the same parent, e.g. two sub-registries depend on semconv core, then we can resolve discrepencies by picking the "latest" version of semconv, assuming we do NOT have a major version conflict.

Note: Until semconv goes 1.x this will conflict for every releease.

cc @open-telemetry/specs-semconv-maintainers for awareness.

Comment thread crates/weaver_resolver/src/attribute.rs Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 78.03738% with 47 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.3%. Comparing base (dbbabda) to head (671cc7c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_resolver/src/attribute.rs 74.3% 20 Missing ⚠️
crates/weaver_resolver/src/loader.rs 75.3% 19 Missing ⚠️
crates/weaver_resolver/src/dependency.rs 83.3% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1377     +/-   ##
=======================================
- Coverage   82.4%   82.3%   -0.1%     
=======================================
  Files        120     120             
  Lines      10092   10249    +157     
=======================================
+ Hits        8319    8441    +122     
- Misses      1773    1808     +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread crates/weaver_resolver/src/attribute.rs Fixed
Comment thread crates/weaver_resolver/src/attribute.rs Fixed
Comment thread crates/weaver_resolver/src/loader.rs
Comment on lines +249 to +252
schema
.catalog()
.attribute(ar)
.map_or(false, |attr| attr.name == attr_name)
Comment on lines +249 to +252
schema
.catalog()
.attribute(ar)
.map_or(false, |attr| attr.name == attr_name)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants