PoC: Extension System

[xlc]

Prototype an Extension System with following requirements:

• Each extension can be defined as a Rust trait.
• Some macro to read the definitions of it and generate a stable 64 bytes hash as a const ID field as the ExtensionId
  • It should normalize the order of methods and parameter names
  • The parameter type should be considered. But in that case, we will need to be able to generate a stable hash for it. In that case, we need to either use Implement stable type id paritytech/scale-info#182 or have a custom solution
• User should be able to pass a list of Extension implementations, and the ExtensionExecutor should be able to perform discovery and invocation of the methods for an extension.
• Extension can have associated types
• A permission controller to safeguard extensions. For example, we may have an extension that allow arbitrary storage read but only expose it for the usage of offchain context. i.e. it should be disabled when executed via XCM. This also allows the runtime to dynamically disable an extension if needed.

[mise42]

Have a look? https://github.com/open-web3-stack/XCQ/blob/poc-extension-system/poc/extensions/src/lib.rs

User should be able to pass a list of Extension implementations

"User" means Runtime, and the pass is compile-time, right?

[xlc]

"User" means Runtime, and the pass is compile-time, right?

Yes

You can open draft PR for WIP work. It is easier to review in that way

[mise42]

Questions about permission controller:

• Where should I embed the executer context information (XCM/OffChain)? I am skimming through the XCM related chapter In PDA docs.

• allows the runtime to dynamically disable an extension if needed.

Does dynamically mean run-time enable/disable, or we just provide api like add_filter for runtime to impl it? Is this requirement related with #9 ?

[xlc]

• struct Context with a filed source enum InvokeSource { RuntimeAPI, XCM, Extrinsic, Runtime }
• trait PermissionController with something like is_allowed(extensionId: ExtensionId, call: Call, context: Context) and have the executor takes a type implements this trait, and call it before execute an extension method
• impl PermissionController for () that always return true, so it can be used as a default implementation
• The runtime can then have a custom implementation, that checks for the extension id, and some other storages, to determine the return value. We need a pallet for this. No need to do it for PoC.

Something similar to this https://github.com/AcalaNetwork/Acala/blob/eb96173487545fe68ee67ece25c6e34c66148eed/runtime/acala/src/lib.rs#L218