weight_meter by ermalkaleci · Pull Request #395 · open-web3-stack/open-runtime-module-library

ermalkaleci · 2021-03-11T18:50:22Z

xlc · 2021-03-16T04:38:51Z

weight-meter/weight-meter-procedural/src/lib.rs

+	(quote! {
+		#(#attrs)*
+		#vis #sig {
+			orml_weight_meter::start_with(#base_weight);


should avoid hardcode crate name in macro. should be something like $crate::orml_weight_meter::start_with

yeah makes sense

Seems like this works only for macros. Procedural macros are unhygienic https://doc.rust-lang.org/reference/procedural-macros.html

This is how substrate solves it https://github.com/paritytech/substrate/blob/master/frame/support/procedural/tools/src/lib.rs

weight-meter/weight-meter-procedural/src/lib.rs

weight-meter/src/lib.rs

weight-meter/README.md

xlc · 2021-03-16T22:07:45Z

weight-meter/src/meter_std.rs

+
+use super::{Meter, Weight};
+
+static METER: spin::Mutex<Meter> = spin::Mutex::new(Meter {


use thread_local as unit test could be multi threaded

xlc · 2021-03-16T22:08:07Z

weight-meter/src/meter_std.rs

+		meter.used_weight = base;
+	}
+	meter.depth = meter.depth.saturating_add(1);
+	drop(meter);


why do you need explicit drop?

* Use MultiLocation as xtokens transfer dest type. (#396) * Use MultiLocation as xtokens transfer dest type. * Make clippy happy. * Use xcm-handler to execute XCM locally (#401) * Use cumulus xcm-handler to execute XCM locally. * Add docstring for xtokens config. * Replace XcmError::Undefined usage. (#402) * Replace XcmError::Undefined usage. * make clippy happy * Bump and unify serde versions. (#403) * xtokens and xcm-support documentations (#404) * Add xtokens module docstring. * Add xtokens readme. * Add documentations for xcm-support. * Add xtokens and xcm-support entries in main readme. * Add unit tests for xcm-support. (#405) * Added Minterest to the list of users. (#406) * update step guide link * Handle unknown assets in TransactAsset impl (#409) * Handle unknown assets in TransactAsset impl. * More documentations. * Clean code. * Renaming. * Should try to deposit known asset first. * Return error if no UnknownAsset impl. * Make clippy happy. * Fix description and repo link. (#410) * Unknown tokens pallet (#411) * Impl unknown tokens pallet. * Fix workspace pallet path. * Make clippy happy. * Clippy, be happy. * Unit tests. * Remove nonces from oracle pallet. (#413) * refactor rewards (#412) * Bump rococo v1 dependencies (#418) * Fix mocks. * Replace deprecated. * Update orml-unknown-tokens unit tests. (#421) * add build-script-utils from Substrate (#422) * Update README.md (#420) * Update README.md * Update README.md * Bump impl-trait-for-tuples to 0.2.1 (#424) * update Cargo.toml (#429) * add Handler (#431) * remove disable-tokens-by-owner (#434) * Cross-chain transfer rework (#432) * Reserve chain trait. * Rework cross-chain transfer. * Remove relay chain balance convert. * Add 'Parse' trait. * Change transfer_multiasset fn signature. * Add transfer dispatchable call. * Update doc. * Use xcm-simulator to mock network. * Send relay chain asset to sibling unit test. * Move location traits into orml-traits. * Add MultiNativeAsset filter for is reserve check. * More unit tests. * Failing edge case unit tests. * Handle zero amount asset case. * Fix mocks. * Renaming. * Update currency adapter to work with new xtokens impl (#436) * Xcm support implementations rework. * Update xtokens mock. * Use CurrencyId convert. (#437) * Use CurrencyId convert. * Apply review suggestions. * Update xtokens docs. (#438) * Update xtokens docs. * Fix typo. * Update imbalances impl. * Don't deposit failure event in orml-unknown-tokens. (#440) * Don't deposit failure event in orml-unknown-tokens. * Patch substrate/polkadot/cumulus. * Fix patch. * Update README.md (#441) Include Zeitgeist into "Projects using ORML" section * Add PoV size in benchmarking. (#442) * Bump cumulus ref in cargo patch. (#443) * fix missing features (#444) * fix missing features * test with benchmarks * update auction weight (#445) * Bump dependencies. (#448) * Updated Cargo.dev.toml Co-authored-by: Shaun Wang <spxwang@gmail.com> Co-authored-by: dzianis.ramanouski <DenisRomanovsky@users.noreply.github.com> Co-authored-by: Bette <42193328+bette7@users.noreply.github.com> Co-authored-by: wangjj9219 <183318287@qq.com> Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> Co-authored-by: transxask <68648225+transxask@users.noreply.github.com> Co-authored-by: Aaro Perämaa <aaro.peramaa@gmail.com> Co-authored-by: Harald Heckmann <harald.heckmann93@web.de>

* Use MultiLocation as xtokens transfer dest type. (#396) * Use MultiLocation as xtokens transfer dest type. * Make clippy happy. * Use xcm-handler to execute XCM locally (#401) * Use cumulus xcm-handler to execute XCM locally. * Add docstring for xtokens config. * Replace XcmError::Undefined usage. (#402) * Replace XcmError::Undefined usage. * make clippy happy * Bump and unify serde versions. (#403) * xtokens and xcm-support documentations (#404) * Add xtokens module docstring. * Add xtokens readme. * Add documentations for xcm-support. * Add xtokens and xcm-support entries in main readme. * Add unit tests for xcm-support. (#405) * Added Minterest to the list of users. (#406) * update step guide link * Handle unknown assets in TransactAsset impl (#409) * Handle unknown assets in TransactAsset impl. * More documentations. * Clean code. * Renaming. * Should try to deposit known asset first. * Return error if no UnknownAsset impl. * Make clippy happy. * Fix description and repo link. (#410) * Unknown tokens pallet (#411) * Impl unknown tokens pallet. * Fix workspace pallet path. * Make clippy happy. * Clippy, be happy. * Unit tests. * Remove nonces from oracle pallet. (#413) * refactor rewards (#412) * Bump rococo v1 dependencies (#418) * Fix mocks. * Replace deprecated. * Update orml-unknown-tokens unit tests. (#421) * add build-script-utils from Substrate (#422) * Update README.md (#420) * Update README.md * Update README.md * Bump impl-trait-for-tuples to 0.2.1 (#424) * update Cargo.toml (#429) * bencher init commit * split into files * clean deps * add docs * use frame_benchmarking apis * add macro bencher_use to export stuff for bench_runner * * generate weights file * refactor * improvements * CLI Options (#446) * Added command line options for output, headers, and templates * Fixed options to conform to standard cli * Added weight-gen cli * fixed dependencies * Replaced unwraps with expects (#449) * Orml bencher (#451) * add Handler (#431) * remove disable-tokens-by-owner (#434) * Cross-chain transfer rework (#432) * Reserve chain trait. * Rework cross-chain transfer. * Remove relay chain balance convert. * Add 'Parse' trait. * Change transfer_multiasset fn signature. * Add transfer dispatchable call. * Update doc. * Use xcm-simulator to mock network. * Send relay chain asset to sibling unit test. * Move location traits into orml-traits. * Add MultiNativeAsset filter for is reserve check. * More unit tests. * Failing edge case unit tests. * Handle zero amount asset case. * Fix mocks. * Renaming. * Update currency adapter to work with new xtokens impl (#436) * Xcm support implementations rework. * Update xtokens mock. * Use CurrencyId convert. (#437) * Use CurrencyId convert. * Apply review suggestions. * Update xtokens docs. (#438) * Update xtokens docs. * Fix typo. * Update imbalances impl. * Don't deposit failure event in orml-unknown-tokens. (#440) * Don't deposit failure event in orml-unknown-tokens. * Patch substrate/polkadot/cumulus. * Fix patch. * Update README.md (#441) Include Zeitgeist into "Projects using ORML" section * Add PoV size in benchmarking. (#442) * Bump cumulus ref in cargo patch. (#443) * fix missing features (#444) * fix missing features * test with benchmarks * update auction weight (#445) * Bump dependencies. (#448) * Replaced unwraps with expects Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> Co-authored-by: Shaun Wang <spxwang@gmail.com> Co-authored-by: Harald Heckmann <harald.heckmann93@web.de> Co-authored-by: wangjj9219 <183318287@qq.com> Co-authored-by: Shaun Wang <spxwang@gmail.com> Co-authored-by: dzianis.ramanouski <DenisRomanovsky@users.noreply.github.com> Co-authored-by: Bette <42193328+bette7@users.noreply.github.com> Co-authored-by: wangjj9219 <183318287@qq.com> Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> Co-authored-by: transxask <68648225+transxask@users.noreply.github.com> Co-authored-by: Aaro Perämaa <aaro.peramaa@gmail.com> Co-authored-by: Ermal Kaleci <ermalkaleci@gmail.com> Co-authored-by: Harald Heckmann <harald.heckmann93@web.de>

* Added argument to BenchmarkingState

xlc · 2021-05-05T22:01:51Z

replaced by #478

init weight_meter

e62e1ed

ermalkaleci requested review from brettkolodny and xlc March 11, 2021 18:54

ermalkaleci added 12 commits March 11, 2021 22:23

update meter static var

1ee5d69

update workspace

9250171

fmt

8f85cf8

clippy allow unused imports

61615e5

default std

8b465d9

update cargo

8e40a04

remove std

04f659b

revert until fix no_std issue

8edec36

improvements

41136b8

fmt

1485035

update argument extract

0d6c751

package name with orml prefix

135d43d

ermalkaleci linked an issue Mar 12, 2021 that may be closed by this pull request

Weight Meter #340

Open

ermalkaleci added 2 commits March 15, 2021 18:12

update meter to be Mutex

c6040e1

use mutex only in std

c8d7d73

ermalkaleci marked this pull request as ready for review March 15, 2021 21:58

ermalkaleci added 2 commits March 15, 2021 23:04

update README

b857553

update README

d7a3af0

xlc reviewed Mar 16, 2021

View reviewed changes

ermalkaleci added 5 commits March 16, 2021 11:59

update property name

c5ab5a4

separate method injector

5dadd78

docs

46a7969

fmt

d46f3d4

clippy

3116627

xlc requested changes Mar 17, 2021

View reviewed changes

brettkolodny and others added 2 commits April 15, 2021 14:09

ermalkaleci and others added 5 commits April 16, 2021 20:10

fix bencher dependencies

f414550

Removed bin from Cargo.toml (#458)

1ce44f7

Weight meter (#459)

9868581

* Added argument to BenchmarkingState

fix

77c4290

Updated frame-support version (#461)

2d4fe54

xlc closed this May 5, 2021

xlc deleted the weight_meter branch May 5, 2021 22:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

weight_meter#395

weight_meter#395
ermalkaleci wants to merge 29 commits intomasterfrom
weight_meter

ermalkaleci commented Mar 11, 2021 •

edited by xlc

Loading

Uh oh!

xlc Mar 16, 2021

Uh oh!

ermalkaleci Mar 16, 2021

Uh oh!

ermalkaleci Mar 16, 2021

Uh oh!

xlc Mar 17, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xlc Mar 16, 2021

Uh oh!

xlc Mar 16, 2021

Uh oh!

xlc commented May 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		use super::{Meter, Weight};

		static METER: spin::Mutex<Meter> = spin::Mutex::new(Meter {

Conversation

ermalkaleci commented Mar 11, 2021 • edited by xlc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xlc Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

ermalkaleci Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

ermalkaleci Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

xlc Mar 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xlc Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

xlc Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

xlc commented May 5, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ermalkaleci commented Mar 11, 2021 •

edited by xlc

Loading