Skip to content

Use 'select_nth_unstable' to get median. #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaunxw merged 3 commits into from
Apr 28, 2021
Merged

Use 'select_nth_unstable' to get median. #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
920f2ff
Use 'select_nth_unstable' to get median.
shaunxw Apr 28, 2021
04f5531
fix
shaunxw Apr 28, 2021
51cb09b
Update comments doc.
shaunxw Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions oracle/src/default_combine_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ where

let count = values.len() as u32;
let minimum_count = MinimumCount::get();
if count < minimum_count {
if count < minimum_count || count == 0 {
return prev_value;
}

values.sort_by(|a, b| a.value.cmp(&b.value));

let median_index = count / 2;
Some(values[median_index as usize].clone())
let mid_index = count / 2;
// Won't panic as `values` ensured not empty.
let (_, value, _) = values.select_nth_unstable_by(mid_index as usize, |a, b| a.value.cmp(&b.value));
Some(value.clone())
}
}
7 changes: 3 additions & 4 deletions traits/src/data_provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,9 @@ pub fn median<T: Ord + Clone>(mut items: Vec<T>) -> Option<T> {

let mid_index = items.len() / 2;

items.sort();

// Won't panic as guarded items not empty case.
Some(items[mid_index as usize].clone())
// Won't panic as `items` ensured not empty.
let (_, item, _) = items.select_nth_unstable(mid_index);
Some(item.clone())
}

#[macro_export]
Expand Down