[BUGFIX] Fixed data errors on /v2/rulesets/srd_combat-sequence#893
Open
calumbell wants to merge 2 commits intoopen5e:stagingfrom
Open
[BUGFIX] Fixed data errors on /v2/rulesets/srd_combat-sequence#893calumbell wants to merge 2 commits intoopen5e:stagingfrom
/v2/rulesets/srd_combat-sequence#893calumbell wants to merge 2 commits intoopen5e:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issues in the
srd_combat-sequenceV2 Ruleset data:I tested this out on my local environment. The Nuxt warnings about the
<srd:opportunity-attacks>tag being unclosed are gone, and the blockquote is now formatted correctly. Mission accomplished!The ordinals are currently missing from the
<ol>in the blockquote. I have confirmed that this is not due to any errors in the markdown string and the list not getting parsed correctly, but is a bug with the CSS on the front end:Related Issue
Closes #892
How was this tested?
pytest(all tests passing after testing cases updated to reflect content update)