Skip to content

Comments

handle path to remove space#2

Open
hoda-oz wants to merge 1 commit intodevelopfrom
feature/handle-image-path-space
Open

handle path to remove space#2
hoda-oz wants to merge 1 commit intodevelopfrom
feature/handle-image-path-space

Conversation

@hoda-oz
Copy link

@hoda-oz hoda-oz commented Aug 17, 2018

Thanks for submitting a PR! Please read these instructions carefully:

  • Explain the motivation for making this change.
  • Provide a test plan demonstrating that the code is solid.
  • Match the code formatting of the rest of the codebase.
  • Target the master branch, NOT a "stable" branch.

Motivation (required)

Handle path to remove space.
Due to space, MimeTypeMap.getFileExtensionFromUrl return empty string.
https://developer.android.com/reference/android/webkit/MimeTypeMap.html#getFileExtensionFromUrl(java.lang.String)

Test Plan (required)

A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See What is a Test Plan? to learn more.

If you have added code that should be tested, add tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant