refactor and split GptService #1557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## add_gpt_api_key_per_user #1557 +/- ##
=========================================================
Coverage 93.82% 93.83%
=========================================================
Files 121 123 +2
Lines 2981 2985 +4
=========================================================
+ Hits 2797 2801 +4
Misses 184 184 ☔ View full report in Codecov by Sentry. |
kkoehn
force-pushed
the
add_gpt_api_key_per_user_refactor_services
branch
3 times, most recently
from
04dcd61 to
d109dc0
Compare
kkoehn
force-pushed
the
add_gpt_api_key_per_user_refactor_services
branch
from
d109dc0 to
6dc4adb
Compare
MrSerth
approved these changes
Jul 31, 2024
Member
MrSerth
left a comment
MrSerth
left a comment
There was a problem hiding this comment.
Thanks for your changes, they look great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestion to refactor the
GptGenerateTestsService to something small and handable