Implement missing features for Task Contributions #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fs_task_contrib #1628 +/- ##
===================================================
- Coverage 94.58% 94.49% -0.10%
===================================================
Files 130 130
Lines 3233 3251 +18
===================================================
+ Hits 3058 3072 +14
- Misses 175 179 +4 ☔ View full report in Codecov by Sentry. |
florian-str
approved these changes
Sep 2, 2024
Contributor
florian-str
left a comment
florian-str
left a comment
There was a problem hiding this comment.
Thank you for your input.
MrSerth
force-pushed
the
fs_task_contrib
branch
from
2c3e22f to
5470912
Compare
Previously, both the flash message was incomplete (since it didn't reveal the errors) nor was the action correct (it showed the original task rather than the form to fix problems).
* Make method private * Reduce parameters and avoid passing strings of class names * Overwrite for file specifically
For now, we decided to keep the current behavior. Further investigations should happen in the future, for which we will create a new GitHub issue.
Also, use the newer syntax, so that the code is already compatible with Rails 7.2 and higher.
MrSerth
force-pushed
the
fs_task_contrib_suggestions
branch
from
d607277 to
baaabb9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing functionality as discovered during review / pair programming to PR #1103.
@florian-str I've tested the behavior manually but would like that you add some suitable test cases for the changes I made. Also, please take a moment to carefully read through my changes and check whether I made any mistake or whether something is left unclear.