fix : changed some Files to make app run#2345
Merged
niyajali merged 7 commits intoopenMF:kmp-implfrom Mar 28, 2025
Merged
Conversation
revanthkumarJ
changed the title
Contributor
Author
WhatsApp.Video.2025-03-28.at.11.48.45.AM.mp4 |
niyajali
requested changes
Mar 28, 2025
Collaborator
niyajali
left a comment
niyajali
left a comment
There was a problem hiding this comment.
Move/copy the required drawable to the specific module where it has been used.
Contributor
Author
I have tried it also but the issue is as SearchScreen is in android it gives drawables as Int where as UI is cmp it expects it as DrawableResource that is the issue i am facing if i uncomment that code |
Contributor
Author
|
@niyajali i have copied those drawables to that module |
Contributor
Author
|
|
Collaborator
|
Is this latest image of your commits? |
Contributor
Author
|
@niyajali yes brother after changing that drawables to imageVector i runned the application it is from there |
niyajali
approved these changes
Mar 28, 2025
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* changed Files to make app run * updated * updated * updated * updated * updated
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* changed Files to make app run * updated * updated * updated * updated * updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#434
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.