feat (core:dataStore) Migrated to KMP#2352
Merged
therajanmaurya merged 22 commits intoopenMF:kmp-implfrom Apr 4, 2025
Merged
Conversation
Contributor
Author
|
@itsPronay I have resolved all errors in this , build is fine but app is crashing saying the Instance is not created for koin. Can you look into it after your common PR |
Contributor
Author
WhatsApp.Video.2025-04-01.at.8.48.05.PM.mp4 |
# Conflicts: # feature/auth/src/main/java/com/mifos/feature/auth/login/LoginViewModel.kt # feature/center/src/main/java/com/mifos/feature/center/syncCentersDialog/SyncCentersDialogViewModel.kt # feature/client/src/main/java/com/mifos/feature/client/syncClientDialog/SyncClientsDialogViewModel.kt # feature/groups/src/main/java/com/mifos/feature/groups/syncGroupDialog/SyncGroupsDialogViewModel.kt # feature/settings/src/main/java/com/mifos/feature/settings/settings/SettingsScreen.kt
itsPronay
reviewed
Apr 1, 2025
core/network/src/main/java/com/mifos/core/network/datamanager/DataManagerGroups.kt
Outdated
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/com/mifos/core/model/objects/users/User.kt
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/BaseApiManager.kt
Outdated
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/MifosInterceptor.kt
Outdated
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/datamanager/DataManagerCenter.kt
Outdated
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/datamanager/DataManagerCenter.kt
Outdated
Show resolved
Hide resolved
...client/src/main/java/com/mifos/feature/client/syncClientDialog/SyncClientsDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...data-table/src/main/java/com/mifos/feature/dataTable/dataTableList/DataTableListViewModel.kt
Outdated
Show resolved
Hide resolved
feature/path-tracking/src/main/java/com/mifos/feature/pathTracking/PathTrackingViewModel.kt
Show resolved
Hide resolved
feature/path-tracking/src/main/java/com/mifos/feature/pathTracking/PathTrackingViewModel.kt
Outdated
Show resolved
Hide resolved
feature/path-tracking/src/main/java/com/mifos/feature/pathTracking/PathTrackingViewModel.kt
Show resolved
Hide resolved
Collaborator
|
@revanthkumarJ Is it ready for merge? |
Contributor
Author
still doing some changes , i will update once all done |
itsPronay
reviewed
Apr 3, 2025
feature/groups/src/main/java/com/mifos/feature/groups/createNewGroup/CreateNewGroupScreen.kt
Outdated
Show resolved
Hide resolved
itsPronay
suggested changes
Apr 3, 2025
Comment on lines
30
to
36
| single<UserPreferencesRepository> { | ||
| UserPreferencesRepositoryImpl( | ||
| preferenceManager = get(), | ||
| ioDispatcher = get(named(MifosDispatchers.IO.name)), | ||
| unconfinedDispatcher = get(named(MifosDispatchers.Unconfined.name)), | ||
| ) | ||
| } |
Contributor
There was a problem hiding this comment.
Since it's a repo and we are providing implementation here, use bind instead. See repositoryModule for reference.
Comment on lines
+10
to
+30
| package com.mifos.core.datastore.model | ||
| import com.mifos.core.common.enums.MifosAppLanguage | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class AppSettings( | ||
| val tenant: String, | ||
| val baseUrl: String, | ||
| val passcode: String? = null, | ||
| val appTheme: AppTheme = AppTheme.SYSTEM, | ||
| val language: MifosAppLanguage, | ||
| ) { | ||
| companion object { | ||
| val DEFAULT = AppSettings( | ||
| tenant = "default", | ||
| baseUrl = "https://tt.mifos.community/", | ||
| appTheme = AppTheme.SYSTEM, | ||
| language = MifosAppLanguage.SYSTEM_LANGUAGE, | ||
| ) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
@niyajali Could you please take a look here? I was wondering when we already have ServerConfig defined, Do we really need to set the baseUrl , tenant again in this instance, or is there a reason it's being redefined here?!
Contributor
Author
There was a problem hiding this comment.
if we can add passcode, appTheme, language in ServerConfig then we can replace AppSettings
itsPronay
reviewed
Apr 3, 2025
Comment on lines
36
to
38
| return prefManager.userInfo.flatMapLatest { | ||
| userData -> | ||
| when (userData.userStatus) { |
Contributor
There was a problem hiding this comment.
could you please format these type of lines? should be this instead
return prefManager.userInfo.flatMapLatest { userData ->
when (userData.userStatus) {
false -> flow {
Contributor
|
@revanthkumarJ, please don't resolve conversations on your own. Please let the maintainer resolve them. |
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* Initial Commit * updated * updated * updated * updated * Updated * Updated * Updated * Updated * Updated * updated * updated * updated * updated * updated * updated * Updated * Updated * Updated * Updated * Updated
itsPronay
pushed a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* Initial Commit * updated * updated * updated * updated * Updated * Updated * Updated * Updated * Updated * updated * updated * updated * updated * updated * updated * Updated * Updated * Updated * Updated * Updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#MIFOSAC-330
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.