Skip to content

fix: Settings Module Enhancements (Theme Change and Clean Up)#2403

Merged
niyajali merged 10 commits intoopenMF:kmp-implfrom
revanthkumarJ:settingsEnhancements
Jun 11, 2025
Merged

fix: Settings Module Enhancements (Theme Change and Clean Up)#2403
niyajali merged 10 commits intoopenMF:kmp-implfrom
revanthkumarJ:settingsEnhancements

Conversation

@revanthkumarJ
Copy link
Contributor

@revanthkumarJ revanthkumarJ commented Jun 10, 2025

Fixes - Jira-#450

WhatsApp.Video.2025-06-10.at.9.17.46.PM.mp4

@revanthkumarJ revanthkumarJ marked this pull request as ready for review June 10, 2025 15:35
@revanthkumarJ
Copy link
Contributor Author

@itsPronay any other changes?

@niyajali
Copy link
Collaborator

@itsPronay review this one

@revanthkumarJ revanthkumarJ force-pushed the settingsEnhancements branch from 2406776 to d1f9d6a Compare June 10, 2025 18:42
@revanthkumarJ
Copy link
Contributor Author

@itsPronay now splash screen is showing while state is loading

@itsPronay
Copy link
Contributor

@revanthkumarJ we are supposed to replace first splash screen with our own custom splash screen right? but here it is showing 2 splash screen if you notice.

@itsPronay now splash screen is showing while state is loading

@revanthkumarJ we are supposed to replace the first splash screen with our own custom splash screen right? but here it is showing 2 splash screens if you notice.

@revanthkumarJ
Copy link
Contributor Author

@itsPronay ok i will remove the first one then

@biplab1
Copy link
Contributor

biplab1 commented Jun 11, 2025

@revanthkumarJ We’re looking to verify the navigation flow and ensure that navigation to all features is working correctly as expected.
Could you please upload a screen recording showing the complete flow—starting from the splash screen and login, and covering all features that have been migrated to CMP with an existing navigation route?

@revanthkumarJ revanthkumarJ force-pushed the settingsEnhancements branch from d9c68fd to 7f3cff7 Compare June 11, 2025 05:19
@revanthkumarJ
Copy link
Contributor Author

revanthkumarJ commented Jun 11, 2025

WhatsApp.Video.2025-06-11.at.5.10.18.PM.mp4

@biplab1 this is the latest video
For clarity what achieves in this pr:

  • uncommented the code in settings module which was commented by Aditya due to some issues at that time
  • implemented theming
  • previously while the MainUiState loading login screen comes for 5 to 10 sec now replaced with loader
  • removed the splash module after asking niyaj brother as other projects only use Theme.xml and no custom splash module is needed
  • back icon navigation issue will be solved by Pronay

@revanthkumarJ
Copy link
Contributor Author

@itsPronay can you review once

@niyajali niyajali enabled auto-merge (squash) June 11, 2025 12:22
@biplab1
Copy link
Contributor

biplab1 commented Jun 11, 2025

@revanthkumarJ Thanks for clarifying. Since this PR is focused on the settings module, the video makes sense for that scope.
We can revisit a full navigation flow check once all relevant features are integrated and ready for review.

@niyajali niyajali merged commit d54c6fb into openMF:kmp-impl Jun 11, 2025
2 checks passed
itsPronay pushed a commit to itsPronay/android-client that referenced this pull request Aug 5, 2025
itsPronay pushed a commit to itsPronay/android-client that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants