fix: Settings Module Enhancements (Theme Change and Clean Up)#2403
fix: Settings Module Enhancements (Theme Change and Clean Up)#2403niyajali merged 10 commits intoopenMF:kmp-implfrom
Conversation
feature/settings/src/commonMain/kotlin/com/mifos/feature/settings/settings/SettingsScreen.kt
Show resolved
Hide resolved
|
@itsPronay any other changes? |
cmp-navigation/src/commonMain/kotlin/cmp/navigation/ComposeApp.kt
Outdated
Show resolved
Hide resolved
|
@itsPronay review this one |
cmp-navigation/src/commonMain/kotlin/cmp/navigation/ComposeApp.kt
Outdated
Show resolved
Hide resolved
2406776 to
d1f9d6a
Compare
|
@itsPronay now splash screen is showing while state is loading |
|
@revanthkumarJ we are supposed to replace first splash screen with our own custom splash screen right? but here it is showing 2 splash screen if you notice.
@revanthkumarJ we are supposed to replace the first splash screen with our own custom splash screen right? but here it is showing 2 splash screens if you notice. |
|
@itsPronay ok i will remove the first one then |
|
@revanthkumarJ We’re looking to verify the navigation flow and ensure that navigation to all features is working correctly as expected. |
d9c68fd to
7f3cff7
Compare
WhatsApp.Video.2025-06-11.at.5.10.18.PM.mp4@biplab1 this is the latest video
|
|
@itsPronay can you review once |
cmp-navigation/src/commonMain/kotlin/cmp/navigation/ComposeApp.kt
Outdated
Show resolved
Hide resolved
cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/RootNavGraph.kt
Outdated
Show resolved
Hide resolved
|
@revanthkumarJ Thanks for clarifying. Since this PR is focused on the settings module, the video makes sense for that scope. |
Fixes - Jira-#450
WhatsApp.Video.2025-06-10.at.9.17.46.PM.mp4