Feature/mifosac 579 client fields#2517
Closed
SnehaghoshBarsha444 wants to merge 4 commits intoopenMF:developmentfrom
Closed
Feature/mifosac 579 client fields#2517SnehaghoshBarsha444 wants to merge 4 commits intoopenMF:developmentfrom
SnehaghoshBarsha444 wants to merge 4 commits intoopenMF:developmentfrom
Conversation
…submission Co-authored-by: SnehaghoshBarsha444 <153223798+SnehaghoshBarsha444@users.noreply.github.com>
revanthkumarJ
suggested changes
Oct 6, 2025
Contributor
revanthkumarJ
left a comment
There was a problem hiding this comment.
and also upload a video showing what you changed and how it reflects
| ) | ||
| } | ||
| client?.clientType?.let { | ||
| MifosClientDetailsText( |
Merged
2 tasks
Contributor
|
@SnehaghoshBarsha444 Thank you for our initial contribution in this issue. As the reviews were not addressed from a long time, hence a new PR #2578 has been opened with the related changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#Issue_Number->MIFOSAC-579
Please make sure these boxes are checked before submitting your pull request - thanks!
[✔️] Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anything[✔️] If you have multiple commits please combine them into one commit by squashing them.