Skip to content

fixed MIFOSAC-626 :Remove toolbar in client details#2581

Merged
niyajali merged 2 commits intoopenMF:developmentfrom
gurnoorpannu:fix/remove-screen-toolbar
Jan 26, 2026
Merged

fixed MIFOSAC-626 :Remove toolbar in client details#2581
niyajali merged 2 commits intoopenMF:developmentfrom
gurnoorpannu:fix/remove-screen-toolbar

Conversation

@gurnoorpannu
Copy link
Contributor

@gurnoorpannu gurnoorpannu commented Jan 24, 2026

Fixes - Jira-#MIFOSAC-626

Before:
image

After:
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

  • Refactor
    • Removed the title and back-navigation controls from the client profile screen scaffold; layout and content remain state-driven and otherwise unchanged. No public API or exported entities were modified. This is a minor UI cleanup with no functional impact and an estimated review effort of minor.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 24, 2026

📝 Walkthrough

Walkthrough

Removed the title and onBackPressed arguments from the MifosScaffold call in ClientProfileScreen, and removed the associated client_profile_title import; scaffold structure and state-driven rendering remain unchanged.

Changes

Cohort / File(s) Summary
UI Component Simplification
feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientProfile/ClientProfileScreen.kt
Removed title and onBackPressed arguments from the MifosScaffold invocation and removed the client_profile_title import. No other structural or rendering changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • Nagarjuna0033
  • revanthkumarJ

Poem

🐰 A title hopped off, a back-press set free,
The scaffold stays cozy, as calm as can be.
No bar at the top, no button to pry,
Just content and calm beneath the sky. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the toolbar from the client details screen, which matches the code modification (removed MifosScaffold title and onBackPressed arguments).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gurnoorpannu gurnoorpannu force-pushed the fix/remove-screen-toolbar branch from bbaf1b3 to fe69f02 Compare January 25, 2026 05:23
@niyajali niyajali merged commit f02941b into openMF:development Jan 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants