fixing MIFOSAC-632 : added backnavigation on ClientCollateralDetailSc…

[gurnoorpannu]

Fixes - Jira-#MIFOSAC-632

Before:

WhatsApp.Video.2026-01-27.at.15.17.47.mp4

After:

WhatsApp.Video.2026-01-27.at.15.19.26.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

• Bug Fixes
  • Improved back button navigation handling on the Collateral Details screen, ensuring proper navigation flow when users return to the previous screen.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates ClientCollateralDetailScreen navigation to accept an onNavigateBack callback parameter, which is passed through the navigation route and integrated with MifosScaffold's back button handler, enabling proper navigation flow control.

Changes

Cohort / File(s)	Summary
Navigation Route Updates feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientCollateralDetails/ClientCollateralDetailRoute.kt	Added named parameter navController and new onNavigateBack callback that invokes navController.navigateUp() when back navigation is triggered
Screen Composable Updates feature/client/src/commonMain/kotlin/com/mifos/feature/client/clientCollateralDetails/ClientCollateralDetailScreen.kt	Added onNavigateBack parameter to both ClientCollateralDetailScreen and ClientCollateralDetailScreenContent composables; wired callback to MifosScaffold's onBackPressed handler

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat : collateral data screen added #2546: Updates nav destination invocation to pass the newly added onNavigateBack callback into ClientCollateralDetailScreen
• MIFOSAC-618 Added toolbar in Navigation Drawer items sections #2567: Modifies MifosScaffold to render back navigation UI, complementing this PR's callback wiring for back button behavior

Suggested reviewers

• revanthkumarJ
• niyajali

Poem

🐰 A rabbit hops back through the collateral maze,
With callbacks now guiding through navigation's phase,
Each detail screen knows when to retreat with grace,
Back buttons aligned in their proper place! 🔙✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: adding back-navigation functionality to the ClientCollateralDetailScreen component, which aligns with the code changes in the pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[biplab1]

Looks good to me. This can be merged.

[biplab1]

@gurnoorpannu Can you please update branch? After this, you may request for merge.

[gurnoorpannu]

@gurnoorpannu Can you please update branch? After this, you may request for merge.

sure sir

[biplab1]

@niyajali Could you please merge this?

[itsPronay]

@gurnoorpannu @biplab1 ,
Hello this PR is invalid, as it does not solve any issue. We are supposed to get rid of the old topbar instead of adding back its functionalities.

In this screen, in MifosBreadCrumb, we already have new navigateBack functionality implemented, and we navigate back with that.

@Arinyadav1 has already created a PR to solve this issue here https://github.com//pull/2587

[gurnoorpannu]

@itsPronay oh okay

[biplab1]

@itsPronay Good catch, thanks!

[biplab1]

@gurnoorpannu Feel free to close this PR with this comment below:

Close in reference to #2587