2997: Rate Module#3000
Conversation
| scope.rateOptions.splice(scope.rateOptions.indexOf(currentRate),1); | ||
| scope.currentRate = ''; | ||
| currentRate = ''; | ||
| console.log(scope.rateOptions); |
| scope.formData.maxInterestRatePerPeriod = total; | ||
| scope.calculatedRatePerPeriod = total; | ||
|
|
||
| console.log(scope.formData); |
| // | ||
| // scope.incomeAccountOptions = data.incomeOrLiabilityAccountOptions.incomeAccountOptions || []; | ||
| // scope.liabilityAccountOptions = data.incomeOrLiabilityAccountOptions.liabilityAccountOptions || []; | ||
| // scope.incomeAndLiabilityAccountOptions = scope.incomeAccountOptions.concat(scope.liabilityAccountOptions); |
There was a problem hiding this comment.
remove commented code
| scope.rateOptions = [{id : "m_loan"}]; | ||
|
|
||
|
|
||
| scope.rateAppliesToSelected = function (rateAppliesId) { |
There was a problem hiding this comment.
what is the purpose of this function
There was a problem hiding this comment.
Honestly it doesn't seems to do something important. Someone else worked in the code before me so my best bet is that it was used just for some tests
| resourceFactory.rateResource.save(this.formData, function (data) { | ||
| location.path('/rates/'); | ||
| },function(error){ | ||
| console.log(error); |
| scope.formData.maxInterestRatePerPeriod = total; | ||
| scope.calculatedRatePerPeriod = total; | ||
|
|
||
| console.log(scope.formData); |
There was a problem hiding this comment.
also remove extra new lines used in different files
angelboxes
force-pushed
the
2997
branch
2 times, most recently
from
8135cee to
df43a9e
Compare
angelboxes
force-pushed
the
2997
branch
2 times, most recently
from
89c8df2 to
7fa2839
Compare
|
@vorburger @angelboxes is this PR a complement to https://issues.apache.org/jira/browse/FINERACT-614 and apache/fineract#592 ? Seems there are merge conflicts, @angelboxes , will u like to adjust them? |
Hi Awasum, sorry for the late response, yes it is related, let me check the merge conflict and make sure that this work with the latest fineract version. |
|
@angelboxes Are you able to check the merge conflicts here? We are FINALLY going to ship this in Fineract 1.4 and Mifos X 20.08 |
Sorry Ed, I wasn't able to read any messages I've received from github, I will check the confilcts |
angelboxes
force-pushed
the
2997
branch
3 times, most recently
from
0025b2b to
732810c
Compare
|
Hi @edcable, I've reabased the branch twice to fix the merge conflicts. |
|
Sorry @angelboxes there's one more merge conflict now. Can you please address? |
|
@bharathcgowda have you had a chance to do functional review of this yet? |
bharathcgowda
left a comment
bharathcgowda
left a comment
There was a problem hiding this comment.
Functionality is good to have, which enhances the user experience. Functionally I would like to approve this Feature.
New pages were added for Rate definition and rates can be added in loan products and accounts
|
@angelboxes Thanks for all your work. Just fix this last merge conflict on the tranlation file and I will merge this PR immediately after that. Again, sorry for the delay. |
awasum
left a comment
awasum
left a comment
There was a problem hiding this comment.
LGTM except the small merge conflict with the translation file. I will merge this once that is fixed.
|
Hi everyone, I've update again my branch with the latest changes from dev. |
5 participants
New pages were added for Rate definition and rates can be added in loan products and accounts
Description
A new rate module was added to create previously defined rates and use them to configure new loan accounts and loan products.
Related issues and discussion
2997
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Validate the JS and HTML files with
grunt validateto detect errors and potential problems in JavaScript code.Run the tests by opening
test/SpecRunner.htmlin the browser to make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
community-app/Contributing.md.