Implemented stub partylookup, approval, ordering, splitting, formatting and mergeBack worker#10
Conversation
|
@avikganguly01 and @fynmanoj please review and merge. Thanks :) |
danishjamal104
force-pushed
the
stub-worker
branch
from
91165fb to
8a15f4b
Compare
| MappingIterator<Transaction> readValues = csvMapper.readerWithSchemaFor(Transaction.class).with(schema).readValues(csvFile); | ||
|
|
||
| while (readValues.hasNext()) { | ||
| /*while (readValues.hasNext()) { |
There was a problem hiding this comment.
remove these commented lines
There was a problem hiding this comment.
this will be removed in upcoming PRs, since this PR scope is to only add empty Worker and disabled Kafka, so commented out related code in the entire code base.
| fileWriter.close(); | ||
|
|
||
| logger.info(csvData); | ||
| logger.info(""+file.length()); |
There was a problem hiding this comment.
logger.info("{}", file.length()); this is the best way to use logger statements, it removes the overhead of string concatenation.
There was a problem hiding this comment.
this is just for testing purposes and will be removed in upcoming PRs.
| file.setWritable(true); | ||
| file.setReadable(true); | ||
|
|
||
| String csvData = exchange.getIn().getBody(String.class); |
There was a problem hiding this comment.
what is the max size of the file? I don't think it is the right approach if the file size can be very large.
There was a problem hiding this comment.
Not focusing on this issue rit now.
There was a problem hiding this comment.
I think this can be considered in phase 2 or 3.
| MappingIterator<Transaction> readValues = csvMapper.readerWithSchemaFor(Transaction.class).with(schema).readValues(csvFile); | ||
|
|
||
| while (readValues.hasNext()) { | ||
| /*while (readValues.hasNext()) { |
There was a problem hiding this comment.
this will be removed in upcoming PRs, since this PR scope is to only add empty Worker and disabled Kafka, so commented out related code in the entire code base.
| client.containerName(bucketName).blobName(fileName).buildClient().upload(Files.newInputStream(file.toPath()), file.length()); | ||
| return fileName; | ||
| } catch (IOException e) { | ||
| logger.error("Error uploading file to Azure", e); |
There was a problem hiding this comment.
is this as per design to suppress the exception here?
There was a problem hiding this comment.
yes, If staging fail is the incident. We cant move ahead without this step.
2 participants
No description provided.