Adding implementation for phased callback#48
Merged
Conversation
5 tasks
fynmanoj
suggested changes
Feb 16, 2023
ankita10r
force-pushed
the
newPhaseCallback
branch
2 times, most recently
from
498e799 to
7fca78a
Compare
ankita10r
force-pushed
the
newPhaseCallback
branch
from
7fca78a to
3e6d899
Compare
ankita10r
force-pushed
the
newPhaseCallback
branch
from
3e6d899 to
2888b19
Compare
fynmanoj
approved these changes
Feb 23, 2023
| international-remittance-payer: "international_remittance_payer_process-{dfspid}" | ||
| debit-party-process: "debit_party_process-{dfspid}" | ||
| bulk-processor: "bulk_processor-ibank-usa" | ||
| bulk-processor: "bulk_processor-{dfspid}" |
| retry++; | ||
| logger.info("Retry Left {}, Setting Callback as Failed and Retrying...", | ||
| ((int) exchange.getProperty(MAX_STATUS_RETRY) - retry)); | ||
| ((int) exchange.getProperty(MAX_CALLBACK_RETRY) - retry)); |
Contributor
There was a problem hiding this comment.
use Integer or avoid typecasting
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pr includes changes pertaining to implementation of phased callback for bulk disbursement.
The following points are covered by the PR:
Related PRs: openMF/ph-ee-env-labs#29 and
(Ignore if these details are present on the associated JIRA ticket)
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Design related bullet points or design document link related to this PR added in the description above.
Updated corresponding Postman Collection or Api documentation for the changes in this PR.
Create/update unit or integration tests for verifying the changes made.
Add required Swagger annotation and update API documentation with details of any API changes if applicable
Followed the naming conventions as given in https://docs.google.com/document/d/1Q4vaMSzrTxxh9TS0RILuNkSkYCxotuYk1Xe0CMIkkCU/edit?usp=sharing