Skip to content

refactor: modularize payment hub routing#111

Open
Rahulchaudharyji2 wants to merge 4 commits into
openMF:devfrom
Rahulchaudharyji2:refactor/modular-routing
Open

refactor: modularize payment hub routing#111
Rahulchaudharyji2 wants to merge 4 commits into
openMF:devfrom
Rahulchaudharyji2:refactor/modular-routing

Conversation

@Rahulchaudharyji2
Copy link
Copy Markdown

Description

This PR addresses #108 the long-standing TODO in the PaymentHubRoutingModule to separate routing into clean feature modules.

Changes:

  • Created dedicated BatchesModule, SubBatchesModule, and TransfersModule.
  • Moved routing logic into specific *-routing.module.ts files within each feature directory.
  • Implemented Lazy Loading for these feature modules in PaymentHubRoutingModule to improve maintainability and potentially reduce initial bundle size.
  • Cleaned up PaymentHubModule by removing unnecessary direct component declarations.

Why: This refactor improves the modularity of the application, makes the codebase easier to navigate for future developers, and resolves technical debt identified in the source code.

Checklist

@Flashl3opard
Copy link
Copy Markdown

Hi @Rahulchaudharyji2 ! Thanks for the PR. Before moving forward, please ensure you’ve signed the CLA, created and linked the relevant Jira ticket, carefully reviewed the CONTRIBUTING.md guideline.
Secondly, squash your changes into a single clean commit.
Please also include relevant screenshots or a short demo video of the implemented changes as well, for easier review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants