fix(prefill): resolve prefixed and bare local-name keys in JSON-LD#1
Merged
Conversation
The prefill matcher only compared JSON-LD keys against full SHACL URIs. Pipeline-generated JSON-LD uses prefixed keys (scenario:weatherSummary) and bare local names (weatherSummary), causing all pre-selected values to be missing in the wizard UI. Add three-tier key resolution: full URI, prefix expansion, and local name matching. Also handle array values (join with comma) and filter out wizard steps with no visible fields (validation-only sh:node constraints like ScenarioManifestConstraints). Signed-off-by: Carlo van Driesten <carlo.van-driesten@bmw.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The prefill matcher only compared JSON-LD keys against full SHACL URIs. Pipeline-generated JSON-LD uses prefixed keys (
scenario:weatherSummary) and bare local names (weatherSummary), causing all pre-selected values to be missing in the wizard UI.Changes
prefill.ts — Three-tier key resolution:
@contextprefixesAlso handles array values (e.g.
criticalityFactors: ["high_relative_speed"]) by joining with ", ".shape-to-fields.ts — Added
hasVisibleFields()recursive check that filters out wizard steps where all fields resolve to empty groups (e.g.ScenarioManifestConstraintswhich is a validation-onlysh:nodeconstraint).Tests